Add a field for entering code signing identity #6
Conversation
Code signing identities are often something you'd want to specify differently for an automated build (eg, so your developers can just have developer certs but jenkins can set up for distributing builds)
| @@ -389,6 +394,14 @@ public boolean perform(AbstractBuild build, Launcher launcher, BuildListener lis | |||
| xcodeReport.append(", configurationBuildDir: DEFAULT"); | |||
| } | |||
|
|
|||
| // handle code signing identities | |||
| if (!StringUtils.isEmpty(codeSigningIdentity)) { | |||
| commandLine.add("CODE_SIGN_IDENTITY=" + codeSigningIdentity); | |||
There was a problem hiding this comment.
Your fix might also help to fix this one : https://issues.jenkins-ci.org/browse/JENKINS-12800
But I'm not sure that it works if you have a space in codeSigningIdentity
Did you try it ?
There was a problem hiding this comment.
In fact it does. It's not really the best fix (as there are other options) but that's actually what led me here. I took a few stabs at the regex and decided that this was a quicker path to something working ;-)
|
Can you provide an help file also to document this new configuration field ?? |
|
What would be really cool is if the code signing identity data was stored using the credentials plugin and then transferred to the build slave when needed |
|
@aheritier yep, will add and update the pull request this morning. @stephenc they have to be pulled from the os/x keychain so I'm not sure of any way to actually export/import in an automated fashion |
|
I forgot the other pull request which I think was to solve the same issue. --sign and CODE_SIGN_IDENTITY have the same behavior no ? |
|
There is actually a slight difference from my understanding. CODE_SIGN_IDENTITY has to do with how the .app gets signed. --sign is instead how the packaged .ipa is signed. The two can be different in some cases from what I understand |
|
ok thus I'll keep the other, I'll have to study it more. |
Add a field for entering code signing identity
|
Any word on when a new release will be made with this feature in place? |
|
Any news for a release? I searched this feature on the web |
|
If people want to test the latest build and report. I am unable to deploy to our prod server right now. We are at the end of Should be able in a week or two. Jerome On Fri, Apr 5, 2013 at 2:54 PM, Pierre-Yves Bertholon <
Jerome Lacoste, +47 40867729, We Want To Know |
|
Any updates? Sadly this is a deal-breaker for me... |
|
Have you guys tested the latest build ? If nobody helps me testing the latest HEAD build on a production server, then you have to wait for me to test it :) As said above, I am in the end of a release cycle and will have time in a few days. |
|
Cool. :) I'll test it on our server now... |
|
Works perfectly for me! |
|
If I change the Code Signing Identity to V38B2WC56E Jenkins fails the build and according to the log Any ideas? |
|
Use the name of the signing identity instead ;-) |
Code signing identities are often something you'd want
to specify differently for an automated build (eg, so your
developers can just have developer certs but jenkins can
set up for distributing builds)