Fix for issue JENKINS-20037 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plugins » xcode-plugin #30 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
plugins » xcode-plugin #31 SUCCESS |
…NS-20037] 46f1770 caused the regression in performance seen this issue: https://issues.jenkins-ci.org/browse/JENKINS-20037 Reverting to use the more conservative .matches reduces parse time back to a reasonable level.
|
plugins » xcode-plugin #32 SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-20037
A performance regression was introduced by 46f1770 which cause a reduction in performance by an order of magnitude (4 min builds taking 40 min).
This pull reverts that change and brings build back to previous performance levels.
46f1770 should be re-examined to find a better way of accomplishing its goal without such a drastic impact on performance of the plugin.