Adding restoration of the keychains as a build wrapper #31
Conversation
|
Jenkins » xcode-plugin #63 SUCCESS |
|
Jenkins » xcode-plugin #66 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
@mAu888, clearly you've been actively working on this plugin, yet our existing plugin developers are failing to accomodate those changes in a timely fashion. It'd be great if you can become a committer and push this plugin forward. Let me know if you are OK with my adding you as a committer. This is an important plugin for many, and adding features / fixing issues in a timely fashion is very important. |
Conflicts: src/main/java/au/com/rayh/XCodeBuilder.java
|
The pull request disregards people's existing configuration, which is not a good idea. I've fixed that problem in 497a87a |
|
@kohsuke Thanks for offering me to be a committer. I'd love to actively help in the development of this plugin. On the other hand I feel my Java knowledge is clearly lacking for this task. |
|
Hello, WRT to delays, see the plugin help page in the wiki where I asked for help in a few areas. I now have a few test xcode projects, I just need to take a few hours to set everything up. |
New approach to keychain restoration. I did not consider aborting a build manually in my first pull request. After a bit of research I found that a
BuildWrappershould be the appropriate extension point for restoring the keychains, because it will be run even if the user aborts the build manually.It may be set in the global configuration which keychains are to be restored. See screenshots attached. The switch for the "Restore keychain" field is because of an annoying bug(?). I had checkboxes first, but when checking just a few keychains to be restored, the ones which are not, won't get saved. See https://groups.google.com/forum/?fromgroups#!topic/jenkinsci-dev/PAf3mFWv1LI