Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[FIXED JENKINS-19044] Would like to have a third column of jobs as an
option in the eXtreme Feedback panel
  • Loading branch information
tomaszbech committed Jul 9, 2015
1 parent 3cd55c1 commit fe7e905
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 11 deletions.
2 changes: 1 addition & 1 deletion src/main/java/maps/hudson/plugin/xfpanel/XFPanelView.java
Expand Up @@ -529,7 +529,7 @@ public String getDisplayName() {
public FormValidation doCheckNumColumns(@QueryParameter String value) {
try {
int i = Integer.parseInt(value);
if (i < 1 || i > 2) {
if (i < 1 || i > 6) {
return FormValidation.error(MSG);
}
} catch (NumberFormatException e) {
Expand Down
@@ -1 +1 @@
The number of columns to lay out. Currently valid values are 1 or 2.
The number of columns to lay out. Currently valid values are 1 or 6.
Expand Up @@ -43,22 +43,16 @@
</j:forEach>
</j:when>
<j:otherwise>
<j:set var="width" value="49%" />
<j:set var="widthn" value="${100 / from.numColumns - 1}" />
<j:set var="width" value="${widthn}%" />
<j:set var="float" value="left" />
<j:forEach var="job" items="${jobs}">
<j:set var="dontShowJob" value="false" />
<j:if test="${job.isBuildSuccessful() == true}" >
<j:set var="dontShowJob" value="${it.hideSuccessfulBuilds == true}" />
</j:if>

<j:if test="${dontShowJob == false}">
<j:choose>
<j:when test="${float == 'left'}">
<j:set var="float" value="right" />
</j:when>
<j:otherwise>
<j:set var="float" value="left" />
</j:otherwise>
</j:choose>
<st:include page="job.jelly" />
</j:if>
</j:forEach>
Expand Down

0 comments on commit fe7e905

Please sign in to comment.