Skip to content

Commit

Permalink
[JENKINS-25779] Making DescribableHelper.uninstantiate respect non-nu…
Browse files Browse the repository at this point in the history
…ll default values.

Originally-Committed-As: cfe1713b5fe9e966399ad7a2d47ba86b4058ae8c
  • Loading branch information
jglick committed Feb 22, 2015
1 parent 8134067 commit 24f9192
Showing 1 changed file with 6 additions and 2 deletions.
Expand Up @@ -75,7 +75,12 @@ public class SnippetizerTest {
@Test public void coreStep() throws Exception {
ArtifactArchiver aa = new ArtifactArchiver("x.jar");
aa.setAllowEmptyArchive(true);
assertRoundTrip(new CoreStep(aa), "step([$class: 'ArtifactArchiver', allowEmptyArchive: true, artifacts: 'x.jar', defaultExcludes: true, excludes: '', fingerprint: false, onlyIfSuccessful: false])");
assertRoundTrip(new CoreStep(aa), "step([$class: 'ArtifactArchiver', allowEmptyArchive: true, artifacts: 'x.jar'])");
}

@Ignore("TODO https://github.com/jenkinsci/jenkins/pull/1579 expected:<step[([$class: 'ArtifactArchiver', artifacts: 'x.jar'])]> but was:<step[ <object of type hudson.tasks.ArtifactArchiver>]>")
@Test public void coreStep2() throws Exception {
assertRoundTrip(new CoreStep(new ArtifactArchiver("x.jar")), "step([$class: 'ArtifactArchiver', artifacts: 'x.jar'])");
}

@Test public void blockSteps() throws Exception {
Expand Down Expand Up @@ -103,7 +108,6 @@ public class SnippetizerTest {
*/
}

@Ignore("TODO expected:<input ['Ready?']> but was:<input [id: '9f0de62738120076abeedd636a7629f7', message: 'Ready?', ok: 'Proceed', parameters: []]>")
@Issue("JENKINS-25779")
@Test public void defaultValues() throws Exception {
assertRoundTrip(new InputStep("Ready?"), "input 'Ready?'");
Expand Down

0 comments on commit 24f9192

Please sign in to comment.