Skip to content

Commit

Permalink
[FIXED JENKINS-16474]
Browse files Browse the repository at this point in the history
Based on the feedback from several users, easing this up a little bit, and also reducing the timeout since we see thread dumps where most threads are blocked at the parseURI line.
  • Loading branch information
kohsuke committed Feb 12, 2013
1 parent ffe79e8 commit 3079a06
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/java/winstone/HttpListener.java
Expand Up @@ -35,7 +35,7 @@ public class HttpListener implements Listener, Runnable {
protected static int CONNECTION_TIMEOUT = 60000;
protected static int BACKLOG_COUNT = 5000;
protected static boolean DEFAULT_HNL = false;
protected static int KEEP_ALIVE_TIMEOUT = 10000;
protected static int KEEP_ALIVE_TIMEOUT = 5000;
protected static int KEEP_ALIVE_SLEEP = 20;
protected static int KEEP_ALIVE_SLEEP_MAX = 500;
protected HostGroup hostGroup;
Expand Down
2 changes: 1 addition & 1 deletion src/java/winstone/cmdline/Option.java
Expand Up @@ -87,7 +87,7 @@ public static List<Option<?>> all(Class<?> clazz) {
* and make everyone slow (or worst case choke every request by OOME), so better to err
* on the conservative side (and have inbound connections wait in the queue)
*/
public static final OInt HANDLER_COUNT_MAX =integer("handlerCountMax",20);
public static final OInt HANDLER_COUNT_MAX =integer("handlerCountMax",40);

This comment has been minimized.

Copy link
@jglick

jglick Feb 13, 2013

Member

This again neglected to change the documentation to match the new default value; see ffe79e8 for what to edit.

This comment has been minimized.

Copy link
@kohsuke

kohsuke Feb 13, 2013

Author Member

Addressed in 9b1169d

/**
* Leave this number of request handler threads in the pool even when they are idle.
* Other threads are destroyed when they are idle to free up resources.
Expand Down

0 comments on commit 3079a06

Please sign in to comment.