[FIXED JENKINS-43930] - Fatal file leak on exceptional path when redi…

…rect.log is not writable
jenkinsci · Apr 28, 2017 · 44a08b3 · 44a08b3
1 parent 0d8d917
commit 44a08b3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/main/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstaller.java b/src/main/java/org/jenkinsci/modules/windows_slave_installer/WindowsSlaveInstaller.java
@@ -98,9 +98,9 @@ static int runElevated(File agentExe, String command, TaskListener out, File pwd
         try {
             return Kernel32Utils.waitForExitProcess(sei.hProcess);
         } finally {
-            FileInputStream fin = new FileInputStream(new File(pwd,"redirect.log"));
-            IOUtils.copy(fin,out.getLogger());
-            fin.close();
+            try (FileInputStream fin = new FileInputStream(new File(pwd, "redirect.log"))) {
+                IOUtils.copy(fin,out.getLogger());
+            }
         }
     }