Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Commit

Permalink
Browse files Browse the repository at this point in the history
[FIXED JENKINS-34141] Filenames should not contain spaces.
  • Loading branch information
uhafner committed May 26, 2016
1 parent aa2c058 commit be45bec
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
Expand Up @@ -17,7 +17,7 @@ public class GccParser extends RegexpLineParser {
private static final long serialVersionUID = 2020182274225690532L;
static final String GCC_ERROR = "GCC error";
static final String LINKER_ERROR = "Linker error";
private static final String GCC_WARNING_PATTERN = "^(?:\\s*(?:\\[.*\\]\\s*)?(.*\\.[chpimxsola0-9]+):(?:(\\d*):(?:\\d*:)*\\s*(?:(warning|error|note)\\s*:|\\s*(.*))|\\s*(undefined reference to.*))(.*)|.*ld:\\s*(.*-l(.*)))$";
private static final String GCC_WARNING_PATTERN = "^(?:\\s*(?:\\[.*\\]\\s*)?([^ ]*\\.[chpimxsola0-9]+):(?:(\\d*):(?:\\d*:)*\\s*(?:(warning|error|note)\\s*:|\\s*(.*))|\\s*(undefined reference to.*))(.*)|.*ld:\\s*(.*-l(.*)))$";

/**
* Creates a new instance of {@link GccParser}.
Expand Down
12 changes: 12 additions & 0 deletions src/test/java/hudson/plugins/warnings/parser/GccParserTest.java
Expand Up @@ -19,6 +19,18 @@ public class GccParserTest extends ParserTester {
private static final String GCC_ERROR = GccParser.GCC_ERROR;
private static final String GCC_WARNING = "GCC warning";

/**
* Checks that a false positive is not reported anymore.
*
* @see <a href="http://issues.jenkins-ci.org/browse/JENKINS-34141">Issue 34141</a>
*/
@Test
public void issue34141() throws IOException {
Collection<FileAnnotation> warnings = new GccParser().parse(openFile("issue34141.txt"));

assertEquals(WRONG_NUMBER_OF_WARNINGS_DETECTED, 0, warnings.size());
}

/**
* Verifies that the message contains escaped XML characters.
*
Expand Down
@@ -0,0 +1,2 @@
14:22:36 New: vobs/1062_GEN3/configuration/tools/CSU/device_get_logs_info.sh /main/Integration/2
14:22:36 New: vobs/1062_GEN3/configuration/tools/RIU/device_get_logs_info.sh "symbolic link d6377eb4.fc7711e5.8fd8.00:50:56:bc:54:8e" SYMLINK

0 comments on commit be45bec

Please sign in to comment.