[JENKINS-32298] Fixed false positives after upgrade to JavaDoc 8.

jenkinsci · Jun 4, 2016 · 81c697a · 81c697a
1 parent a9c512c
commit 81c697a
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/main/java/hudson/plugins/warnings/parser/JavaDocParser.java b/src/main/java/hudson/plugins/warnings/parser/JavaDocParser.java
@@ -24,7 +24,12 @@ public JavaDocParser() {
         super(Messages._Warnings_JavaDoc_ParserName(),
                 Messages._Warnings_JavaDoc_LinkName(),
                 Messages._Warnings_JavaDoc_TrendName(),
-                JAVA_DOC_WARNING_PATTERN);
+                JAVA_DOC_WARNING_PATTERN, true);
+    }
+
+    @Override
+    protected boolean isLineInteresting(final String line) {
+        return line.contains("javadoc") || line.contains("@");
     }
 
     @Override

diff --git a/src/test/java/hudson/plugins/warnings/parser/JavaDocParserTest.java b/src/test/java/hudson/plugins/warnings/parser/JavaDocParserTest.java
@@ -18,6 +18,18 @@
 public class JavaDocParserTest extends ParserTester {
     private static final String TYPE = new JavaDocParser().getGroup();
 
+    /**
+     * Parses a warning log with JavaDoc 1.8 warnings.
+     *
+     * @throws IOException
+     *      if the file could not be read
+     */
+    @Test
+    public void falseJavaDocPositives() throws IOException {
+        Collection<FileAnnotation> warnings = new JavaDocParser().parse(openFile("all.txt"));
+        assertEquals(WRONG_NUMBER_OF_WARNINGS_DETECTED, 8, warnings.size());
+    }
+
     /**
      * Parses a warning log with JavaDoc 1.8 warnings.
      *