[JENKINS-47051] Hide plain text link for pipeline steps

Only instances of Run are capable of displaying the plain text or the /timestamps/ page, so hide the link if the context is of a different type.
jenkinsci · May 8, 2018 · b4311e8 · b4311e8
1 parent 53c91f9
commit b4311e8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/main/java/hudson/plugins/timestamper/TimestampNote.java b/src/main/java/hudson/plugins/timestamper/TimestampNote.java
@@ -111,6 +111,9 @@ public ConsoleAnnotator<Object> annotate(Object context, MarkupText text, int ch
     TimestampFormat format = TimestampFormatProvider.get();
     Timestamp timestamp = getTimestamp(context);
     format.markup(text, timestamp);
+    if (!(context instanceof Run<?, ?>)) {
+      text.addMarkup(0, "<style>.timestamper-plain-text {visibility: hidden;}</style>");
+    }
     return null; // each time-stamp note affects one line only
   }
 

diff --git a/...ources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory2/usersettings.jelly b/...ources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory2/usersettings.jelly
@@ -29,7 +29,7 @@ THE SOFTWARE.
       <tr>
         <td class="pane-header">
           <span style="text-align:left;">${%Timestamps}</span>
-          <span style="float:right;"><a href="${it.plainTextUrl}">${%View as plain text}</a></span>
+          <span style="float:right;"><a class="timestamper-plain-text" href="${it.plainTextUrl}">${%View as plain text}</a></span>
         </td>
       </tr>
       <tr>