Added: JENKINS-12275 - TestNG plugin should contribute to Dashboard V…

…iew plugin Updated TestNG's project action to extend the more generic TestResultProjectAction that DashboardView plugin looks for NOTE: this still doesnt fix the Test Trend Chart. Submitted pull request jenkinsci/dashboard-view-plugin#17 to fix that issue.
jenkinsci · Jul 1, 2013 · ca1c5e3 · ca1c5e3
1 parent e19c41f
commit ca1c5e3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/README b/README
@@ -18,6 +18,7 @@ Release Notes
 
 ###
 * Added: JENKINS-11899 - Print all URLs as HTML anchors (when escaping description and exception message)
+* Added: JENKINS-12275 - TestNG plugin should contribute to Dashboard View plugin
 * Fixed: JENKINS-17564 - Reporter output being escaped incorrectly
 
 ### v1.2

diff --git a/src/main/java/hudson/plugins/testng/TestNGProjectAction.java b/src/main/java/hudson/plugins/testng/TestNGProjectAction.java
@@ -10,6 +10,7 @@
 import hudson.model.ProminentProjectAction;
 import hudson.model.Result;
 import hudson.plugins.testng.util.GraphHelper;
+import hudson.tasks.test.TestResultProjectAction;
 import hudson.util.ChartUtil;
 import hudson.util.DataSetBuilder;
 import org.jfree.chart.JFreeChart;
@@ -21,7 +22,7 @@
  *
  * @author nullin
  */
-public class TestNGProjectAction implements ProminentProjectAction {
+public class TestNGProjectAction extends TestResultProjectAction implements ProminentProjectAction {
 
    private boolean escapeTestDescp;
    private boolean escapeExceptionMsg;
@@ -35,7 +36,7 @@ public class TestNGProjectAction implements ProminentProjectAction {
 
    public TestNGProjectAction(AbstractProject<?, ?> project,
          boolean escapeTestDescp, boolean escapeExceptionMsg) {
-      this.project = project;
+      super(project);
       this.escapeExceptionMsg = escapeExceptionMsg;
       this.escapeTestDescp = escapeTestDescp;
    }
@@ -54,18 +55,13 @@ public boolean getEscapeExceptionMsg()
       return escapeExceptionMsg;
    }
 
-   /**
-    * The owner of this action.
-    */
-   private final AbstractProject<?, ?> project;
-
    /**
     * Getter for property 'project'.
     *
     * @return Value for property 'project'.
     */
    public AbstractProject<?, ?> getProject() {
-      return project;
+      return super.project;
    }
 
    /**