[FIXED JENKINS-13491] Center the affected source line in source view.

jenkinsci · Apr 27, 2012 · 240905a · 240905a
1 parent 12b7b88
commit 240905a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/src/main/resources/hudson/plugins/tasks/TasksTabDetail/tasks-details.jelly b/src/main/resources/hudson/plugins/tasks/TasksTabDetail/tasks-details.jelly
@@ -1,6 +1,6 @@
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define"
   xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form"
-  xmlns:i="jelly:fmt" xmlns:local="local">
+  xmlns:i="jelly:fmt" xmlns:local="local" xmlns:u="/util">
   <st:header name="Content-Type" value="text/html;charset=UTF-8" />
   <j:forEach var="file" items="${annotations.files}">
     <table class="pane">
@@ -13,14 +13,7 @@
         <tr>
           <td class="pane">
             <p>
-              <j:choose>
-                <j:when test="${it.isCurrent() and task.canDisplayFile(it.owner)}">
-                  <a href="source.${task.key}/#${task.primaryLineNumber}">${%tasks.line(task.primaryLineNumber)}:</a>
-                </j:when>
-                <j:otherwise>
-                  ${%tasks.line(task.primaryLineNumber)}:
-                </j:otherwise>
-              </j:choose>
+              <u:sourceLink it="${it}" warning="${task}"/>
               ${task.match}
             </p>
           </td>

diff --git a/src/main/resources/hudson/plugins/tasks/TasksTabDetail/tasks-warnings.jelly b/src/main/resources/hudson/plugins/tasks/TasksTabDetail/tasks-warnings.jelly
@@ -1,6 +1,6 @@
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define"
   xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form"
-  xmlns:i="jelly:fmt" xmlns:local="local">
+  xmlns:i="jelly:fmt" xmlns:local="local" xmlns:u="/util">
   <st:header name="Content-Type" value="text/html;charset=UTF-8" />
   <table class="pane sortable" id="warnings">
     <tr>
@@ -15,12 +15,7 @@
         <tr>
           <td class="pane">
             <div tooltip="${warning.message}">
-              <j:choose>
-                <j:when test="${warning.canDisplayFile(it.owner)}">
-                  <a href="source.${warning.key}/#${warning.primaryLineNumber}">${warning.shortFileName}</a>
-                </j:when>
-                <j:otherwise>${warning.shortFileName}</j:otherwise>
-              </j:choose>
+              <u:sourceLink it="${it}" warning="${warning}"/>
             </div>
           </td>
           <td class="pane">