[FIXED JENKINS-37623] Tolerate failed builds when generating tooltips.

jenkinsci · Sep 10, 2016 · 6cde4f7 · 6cde4f7
1 parent a919323
commit 6cde4f7
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/src/main/java/org/tap4j/plugin/TapProjectAction.java b/src/main/java/org/tap4j/plugin/TapProjectAction.java
@@ -249,6 +249,17 @@ protected void populateDataSetBuilder(DataSetBuilder<String, ChartUtil.NumberOnl
         Job<?, ?> p = this.job;
 
         for (Run<?, ?> build = this.job.getLastBuild(); build != null; build = build.getPreviousBuild()) {
+
+            /*
+             * The build has most likely failed before any TAP data was recorded.
+             *
+             * If we don't exclude such builds, we'd have to account for that in GraphHelper. Besides that, it's not
+             * consistent with JUnit graph behaviour where builds without test results are not included in graph.
+             */
+            if (build.getAction(TapBuildAction.class) == null) {
+                continue;
+            }
+
             ChartUtil.NumberOnlyBuildLabel label = new ChartUtil.NumberOnlyBuildLabel((Run) build);
 
             Result r = new Result();