Skip to content

Commit

Permalink
Merge pull request #74 from daniel-beck/notify-commit-external-creden…
Browse files Browse the repository at this point in the history
…tials

[FIXED JENKINS-21785] Check for changes in folders linked via svn:externals fails due to missing credentials

- Typo in original code and externals credentials were not being resolved correctly. Good catch by @daniel-beck
  • Loading branch information
stephenc committed Apr 7, 2014
2 parents 0a17b93 + 69ef77b commit a923c50
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/java/hudson/scm/SubversionSCM.java
Expand Up @@ -2736,7 +2736,7 @@ public SVNRepository openRepository(AbstractProject context, boolean keepConnect
StandardCredentials cred = CredentialsMatchers
.firstOrNull(CredentialsProvider.lookupCredentials(StandardCredentials.class, context,
ACL.SYSTEM, Collections.<DomainRequirement>emptyList()),
CredentialsMatchers.allOf(CredentialsMatchers.withId(credentialsId),
CredentialsMatchers.allOf(CredentialsMatchers.withId(c.getCredentialsId()),
CredentialsMatchers.anyOf(CredentialsMatchers.instanceOf(
StandardCredentials.class), CredentialsMatchers.instanceOf(
SSHUserPrivateKey.class))));
Expand Down

1 comment on commit a923c50

@daniel-beck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fix bugs I introduced (#70). Yay me! 😆

Please sign in to comment.