[FIXED JENKINS-14116] Update to older revision

Added check to generation of change set between previous workspace (prevRev) and current workspace (thisRev) to correctly handle case when prevRev > thisRev. Change set covers commits [prevRev+1, thisRev], which is backwards when updating to an older revision, resulting in an incorrect summary and, if prevRev=HEAD, throwing exceptions and failing the build since HEAD+1 does not exist. Solution: if prevRev > thisRev, swap values before generating change set.
jenkinsci · Aug 22, 2012 · 9a460b8 · 9a460b8
1 parent 7f594bc
commit 9a460b8
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/main/java/hudson/scm/SubversionChangeLogBuilder.java b/src/main/java/hudson/scm/SubversionChangeLogBuilder.java
@@ -151,6 +151,13 @@ private boolean buildModule(String url, SVNLogClient svnlc, SVNXMLLogHandler log
             return false;
         }
 
+        // handle case where previous workspace revision is newer than this revision
+        if (prevRev.compareTo(thisRev) > 0) {
+        	long temp = thisRev.longValue();
+        	thisRev = new Long(prevRev.longValue());
+        	prevRev = new Long(temp);
+        }
+
         try {
             if(debug)
                 listener.getLogger().printf("Computing changelog of %1s from %2s to %3s\n",