[JENKINS-29211] foreach cycle with break would be more readable

jenkinsci · Jul 4, 2015 · 7b7b165 · 7b7b165
1 parent 73c3c5c
commit 7b7b165
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/main/java/hudson/scm/PerJobCredentialStore.java b/src/main/java/hudson/scm/PerJobCredentialStore.java
@@ -115,16 +115,13 @@ private Object writeReplace() {
         CredentialsStore store = CredentialsProvider.lookupStores(project).iterator().next();
         for (Map.Entry<String, Credential> e : credentials.entrySet()) {
             StandardCredentials credential =  descriptor.migrateCredentials(store, e.getKey(), e.getValue());
-            int i = 0;
-            boolean found = false;
             ModuleLocation[] locations = ((SubversionSCM) project.getScm()).getLocations();
-            while (i < locations.length && !found) {
+            for (int i = 0; i < locations.length; i++) {
                 try {
                     if (e.getKey().contains(locations[i].getSVNURL().getHost())) {
                         locations[i].setCredentialsId(credential.getId());
-                        found = true;
+                        break;
                     }
-                    i++;
                 } catch (SVNException ex) {
                     // Should not happen, but...
                     LOGGER.log(WARNING, "Repository location with a malformed URL: " + locations[i].remote, ex);