[FIXED JENKINS-11415] Setting SVN credentials for a job should not re…

…quire administer permission
jenkinsci · Oct 21, 2011 · 522894a · 522894a
1 parent 222fbd6
commit 522894a
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/main/java/hudson/scm/SubversionSCM.java b/src/main/java/hudson/scm/SubversionSCM.java
@@ -44,6 +44,7 @@
 import hudson.model.Computer;
 import hudson.model.Hudson;
 import hudson.model.Hudson.MasterComputer;
+import hudson.model.Item;
 import hudson.model.Node;
 import hudson.model.ParametersAction;
 import hudson.model.Run;
@@ -1789,8 +1790,8 @@ public ISVNAuthenticationProvider createAuthenticationProvider() {
          */
         // TODO: stapler should do multipart/form-data handling 
         public void doPostCredential(StaplerRequest req, StaplerResponse rsp) throws IOException, ServletException {
-            Hudson.getInstance().checkPermission(Hudson.ADMINISTER);
-
+            Hudson.getInstance().checkPermission(Item.CONFIGURE);
+            
             MultipartFormDataParser parser = new MultipartFormDataParser(req);
 
             // we'll record what credential we are trying here.
@@ -1880,8 +1881,8 @@ public FormValidation doCheckRemote(StaplerRequest req, @AncestorInPath Abstract
                 return FormValidation.errorWithMarkup(
                     Messages.SubversionSCM_doCheckRemote_invalidUrl());
 
-            // Test the connection only if we have admin permission
-            if (!Hudson.getInstance().hasPermission(Hudson.ADMINISTER))
+            // Test the connection only if we have job cuonfigure permission
+            if (!Hudson.getInstance().hasPermission(Item.CONFIGURE))
                 return FormValidation.ok();
 
             try {