[JENKINS-16711] SVNPath must be built from a decoded path

jenkinsci · Dec 28, 2015 · 2b160a1 · 2b160a1
1 parent dd63407
commit 2b160a1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/hudson/scm/SubversionSCM.java b/src/main/java/hudson/scm/SubversionSCM.java
@@ -3092,8 +3092,8 @@ public FormValidation checkCredentialsId(StaplerRequest req, @Nonnull Item conte
                     StandardCredentials credentials = lookupCredentials(context, value, repoURL);
                     SVNRepository repo = descriptor().getRepository(context, repoURL, credentials, Collections
                             .<String, Credentials>emptyMap(), null);
-                    String repoRoot = repo.getRepositoryRoot(false).toString();
-                    String repoPath = repo.getLocation().toString().substring(repoRoot.length());
+                    String repoRoot = repo.getRepositoryRoot(false).toDecodedString();
+                    String repoPath = repo.getLocation().toDecodedString().substring(repoRoot.length());
                     SVNPath path = new SVNPath(repoPath, true, true);
                     SVNNodeKind svnNodeKind = repo.checkPath(path.getTarget(), path.getPegRevision().getNumber());
                     if (svnNodeKind != SVNNodeKind.DIR) {

diff --git a/src/main/java/jenkins/scm/impl/subversion/SubversionSCMSource.java b/src/main/java/jenkins/scm/impl/subversion/SubversionSCMSource.java
@@ -242,7 +242,7 @@ protected SCMRevision retrieve(@NonNull SCMHead head, @NonNull TaskListener list
             throws IOException {
         SVNRepositoryView repository = null;
         try {
-            listener.getLogger().println("Opening conection to " + remoteBase);
+            listener.getLogger().println("Opening connection to " + remoteBase);
             SVNURL repoURL = SVNURL.parseURIEncoded(remoteBase);
             repository = openSession(repoURL);
             String repoPath = SubversionSCM.DescriptorImpl.getRelativePath(repoURL, repository.getRepository());