Commit
relates to [JENKINS-12201]
- Loading branch information
There are no files selected for viewing
4 comments
on commit 09f1708
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throwing an exception would make things cleaner, but I'm confused how it will be thrown through the remote channel and we can catch it a consistent way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an unit test for it and you'll know ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The catch block for SVNCancelException already throws an InterruptedException, so throwing an IOException for the general SVNException seems like it would be more consistent than returning null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed at 7f594bc
Javadoc of UpdateTask#perform explicitly states: '@return Where svn:external mounting happened. Can be empty but never null.'
So either we change the Javadoc or - as I'd prefer - throw an exception to indicate the error.