[JENKINS-19465] - Even more FindBugs

jenkinsci · Nov 21, 2017 · 890a7e6 · 890a7e6
1 parent 7051b60
commit 890a7e6
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/hudson/plugins/sshslaves/SSHLauncher.java b/src/main/java/hudson/plugins/sshslaves/SSHLauncher.java
@@ -849,13 +849,14 @@ public Boolean call() throws InterruptedException {
         try {
             long time = System.currentTimeMillis();
             List<Future<Boolean>> results;
-            if (launcherExecutorService == null) {
+            final ExecutorService srv = launcherExecutorService;
+            if (srv == null) {
                 throw new IllegalStateException("Launcher Executor Service should be always non-null here, because the task allocates and closes service on its own");
             }
             if (this.getLaunchTimeoutMillis() > 0) {
-                results = launcherExecutorService.invokeAll(callables, this.getLaunchTimeoutMillis(), TimeUnit.MILLISECONDS);
+                results = srv.invokeAll(callables, this.getLaunchTimeoutMillis(), TimeUnit.MILLISECONDS);
             } else {
-                results = launcherExecutorService.invokeAll(callables);
+                results = srv.invokeAll(callables);
             }
             long duration = System.currentTimeMillis() - time;
             Boolean res;