[JENKINS-46172] Prevent NPE when binding incomplete definitions of ss…

…h host Proper ssh host should have at least: 1. hostname not empty 2. attached credentials
jenkinsci · Mar 25, 2018 · d18d0ed · d18d0ed
1 parent 52bd63a
commit d18d0ed
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/main/java/org/jvnet/hudson/plugins/CredentialsSSHSite.java b/src/main/java/org/jvnet/hudson/plugins/CredentialsSSHSite.java
@@ -70,7 +70,9 @@ private CredentialsSSHSite() {
 	public CredentialsSSHSite(final String hostname, final String port, final String credentialId,
 			final String serverAliveInterval, final String timeout) {
 		final StandardUsernameCredentials credentials = lookupCredentialsById(credentialId);
-		this.username = credentials.getUsername();
+		if (credentials != null) {
+			this.username = credentials.getUsername();
+		}
 
 		this.hostname = hostname;
 		try {