Skip to content

Commit

Permalink
JENKINS-22666: Fix regexp
Browse files Browse the repository at this point in the history
Since PR #19 at GitHub (commit 141cc2b), we don't get a commit message
dialog anymore for changes to job configurations.

The regexp looks broken with the initial slashes and only a single
[^/]. With the Cloudbees Folders plugin jobs can be not only at

  jobs/Some_Job

but also at

  jobs/Folder1/jobs/Folder2/jobs/Some_Job

This commit simplifies the regexp and fixes it.
  • Loading branch information
tomaswolf committed Jul 1, 2015
1 parent 7ad9ae3 commit 83a1bb8
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -19,7 +19,7 @@ public class JobConfigScmSyncStrategy extends AbstractScmSyncStrategy {

// Don't miss to take into account view urls since we can configure a job through a view !
private static final List<PageMatcher> PAGE_MATCHERS = new ArrayList<PageMatcher>(){ {
add(new PageMatcher("^(.*view/[^/]+/)?(/job/[^/])*/job/[^/]+/configure$", "form[name='config']"));
add(new PageMatcher("^(.*view/[^/]+/)?(job/[^/]+/)+configure$", "form[name='config']"));
} };
// Only saving config.xml file located in job directory
// Some plugins (like maven release plugin) could add their own configuration files in the job directory that we don't want to synchronize
Expand Down

0 comments on commit 83a1bb8

Please sign in to comment.