Skip to content

Commit

Permalink
Merge pull request #28 from kuisathaverat/JENKINS-31612
Browse files Browse the repository at this point in the history
[JENKINS-31612] Fix filter chain
  • Loading branch information
wilderrodrigues committed Dec 2, 2016
2 parents f31a787 + dc7808b commit cfa947c
Showing 1 changed file with 4 additions and 5 deletions.
Expand Up @@ -31,12 +31,9 @@
import hudson.model.Descriptor;
import hudson.model.Hudson;
import hudson.model.User;
import hudson.security.GroupDetails;
import hudson.security.UserMayOrMayNotExistException;
import hudson.security.*;
import hudson.tasks.Mailer;
import hudson.tasks.Mailer.UserProperty;
import hudson.security.LDAPSecurityRealm;
import hudson.security.SecurityRealm;
import hudson.util.FormValidation;
import hudson.util.Scrambler;
import hudson.util.spring.BeanBuilder;
Expand Down Expand Up @@ -446,7 +443,7 @@ public String getLDAPURL() {

@Override
public Filter createFilter(FilterConfig filterConfig) {
return new Filter() {
Filter filter = new Filter() {
public void init(FilterConfig filterConfig) throws ServletException {
}

Expand Down Expand Up @@ -555,6 +552,8 @@ public void doFilter(ServletRequest request,
public void destroy() {
}
};
Filter defaultFilter = super.createFilter(filterConfig);
return new ChainedServletFilter(filter, defaultFilter);
}

@Override
Expand Down

2 comments on commit cfa947c

@daniel-beck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wilderrodrigues Is this you?
https://groups.google.com/d/msg/jenkinsci-dev/xWoJSR_jc68/wvqPbUMxCwAJ

If so, please let me know and I will set the account email to your GitHub profile's email address.

@wilderrodrigues
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daniel-beck,

Yep, that's me. :)

Cheers,
Wilder

Please sign in to comment.