Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[FIXED JENKINS-18394]
As a part of the prefetching, Jenkins 1.519 parses classes and tries
to discover other classes that the current class relies on.
"IncompatibleClassChangeError: Implementing class" was encountered
during such analysis phase.

This is a real problem in FindBugs source tree, but the code in question
is never getting exercised, which is why it was working OK.

In this change, I made the prefetching analysis such that it will ignore
the failures encounted during the reference analysis.

I need to start testing plugins with cutting-edge Jenkins version to
detect errors like this before it hits the users.
  • Loading branch information
kohsuke committed Jun 26, 2013
1 parent 781ccae commit bb5aa94
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/main/java/hudson/remoting/RemoteClassLoader.java
Expand Up @@ -766,6 +766,9 @@ public Map<String,ClassFile2> fetch3(String className) throws ClassNotFoundExcep
all.put(other, fetch4(other,cf));
} catch (ClassNotFoundException x) {
// ignore: might not be real class name, etc.
} catch (LinkageError x) {
// maybe this class won't be actually used.
// in any case, this shouldn't cause the loading of the current class to fail
}
}
} catch (IOException e) {
Expand Down

0 comments on commit bb5aa94

Please sign in to comment.