Merge pull request #217 from oleg-nenashev/findbugs-cleanup/ClassFilt…

…er-dead-store [JENKINS-37566] - Get rid of the dead store in RegExpClassFilter#add()
jenkinsci · Nov 12, 2017 · 239f635 · 239f635
2 parents 02fc0a8 + 1d3b294
commit 239f635
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/main/java/hudson/remoting/ClassFilter.java b/src/main/java/hudson/remoting/ClassFilter.java
@@ -217,12 +217,13 @@ void add(String pattern) throws ClassFilterException {
                 // this is a simple startsWith test, no need to slow things down with a regex
                 blacklistPatterns.add(pattern.substring(3, pattern.length() - 4));
             } else {
+                final Pattern regex;
                 try {
-                    Pattern regex = Pattern.compile(pattern);
+                    regex = Pattern.compile(pattern);
                 } catch (PatternSyntaxException ex) {
                     throw new ClassFilterException("Cannot add RegExp class filter", ex);
                 }
-                blacklistPatterns.add(Pattern.compile(pattern));
+                blacklistPatterns.add(regex);
             }
         }