Skip to content

Commit

Permalink
[INFRA-588] Overwrite distribution management
Browse files Browse the repository at this point in the history
  • Loading branch information
vjuranek committed Oct 19, 2016
1 parent 29224df commit 874a281
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions pom.xml
Expand Up @@ -66,6 +66,13 @@
</plugins>
</build>

<distributionManagement>
<repository>
<id>repo.jenkins-ci.org</id>
<url>https://repo.jenkins-ci.org/releases</url>
</repository>
</distributionManagement>

<repositories>
<repository>
<id>repo.jenkins-ci.org</id>
Expand Down

6 comments on commit 874a281

@daniel-beck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vjuranek Consider using the 2.x parent POMs (2.4 or higher for this issue) that let you independently define the Jenkins version you're compatible with instead.

@vjuranek
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @daniel-beck it's on my todo list - I wanted to test it carefully if updating to 2.x parent can break something, so based on this comment I guess there aren't any known issues...

@daniel-beck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vjuranek If so, shouldn't be too severe given the number of plugins doing that already. if you find something, please file and feel free to ping me.

@vjuranek
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-beck sure, I'll rise an issue if I run into some problems (I also don't expect any issues as I haven't seen any complains, but I just didn't want to blindly apply some changes, as I'm not very familiar with 2.X changes in the core (another item on my todo list:-))

@daniel-beck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vjuranek

2.X changes in the core

Please note that the 2.x plugins POM has been made independent of the Jenkins version dependency. So you can keep the 1.580 dependency on core while getting the 2.x plugins POM goodness.

See https://github.com/jenkinsci/plugin-pom and https://github.com/jenkinsci/maven-hpi-plugin/blob/master/hpi-archetype/pom.xml

@vjuranek
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-beck yes, I'm aware I can use 2.X parent pom while stick with 1.X Jenkins core via setting up <jenkins.version>, I used bad wording, I meant I needs to become more familiar with all the 2.X changes, including POM restructure

Please sign in to comment.