[FIXED JENKINS-12799]

Do not allow non-active promotion process to promote a build
jenkinsci · Oct 30, 2012 · 2f054ac · 2f054ac · jglick · Oct 31, 2012
1 parent 932a018
commit 2f054ac
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java b/src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java
@@ -299,6 +299,9 @@ public boolean considerPromotion(AbstractBuild<?,?> build) throws IOException {
      *      null if the build was not promoted, otherwise Future that kicks in when the build is completed.
      */
     public Future<Promotion> considerPromotion2(AbstractBuild<?,?> build) throws IOException {
+        if (!isActive())
+            return null;    // not active
+
         PromotedBuildAction a = build.getAction(PromotedBuildAction.class);
 
         // if it's already promoted, no need to do anything.
@@ -461,6 +464,10 @@ public String getShortUrl() {
         return "";
     }
 
+    public boolean isActive() {
+        return !isDisabled();
+    }
+
     @Extension
     public static class DescriptorImpl extends Descriptor<PromotionProcess> {
         @Override