Merge pull request #71 from bheiskell/fix/promotion/phantom

[FIXED JENKINS-27716] - Disable archived promotion jobs
jenkinsci · Nov 11, 2015 · 2c7603e · 2c7603e
2 parents 89aa15d + 2a33fc6
commit 2c7603e
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java b/src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java
@@ -157,6 +157,15 @@ public AbstractProject<?,?> getOwner() {
         return getOwner().getACL();
     }
 
+    /**
+     * JENKINS-27716: Since 1.585, the promotion must explicitly indicate that
+     * it can be disabled. Otherwise, promotions which trigger automatically
+     * upon build completion will execute, even if they're archived.
+     */
+    @Override public boolean supportsMakeDisabled() {
+        return true;
+    }
+
     /**
      * Get the promotion condition by referencing it fully qualified class name
      */