Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Merge pull request #65 from jglick/executable-war-JENKINS-24064
[JENKINS-24064] Replace war-for-test classifier with executable-war type
  • Loading branch information
jglick committed May 25, 2017
2 parents cd54576 + cf6e467 commit 356fcf3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 35 deletions.
23 changes: 3 additions & 20 deletions README.md
Expand Up @@ -13,6 +13,7 @@ thought to be overridden are no longer based on properties. The main remaining o
Uses split test-harness (see [JENKINS-32478](https://issues.jenkins-ci.org/browse/JENKINS-32478)).
If the required Jenkins version is 1.580.1 or higher, JTH 2.1+ is recommended.
* `hpi-plugin.version`: The HPI Maven Plugin version used by the plugin.
(Generally you should not set this to a version _lower_ than that specified in the parent POM.)
* `stapler-plugin.version`: The Stapler Maven plugin version required by the plugin.
* `java.level`: The Java version to use to build the plugin.
* `java.level.test`: The Java version to use to build the plugin tests.
Expand All @@ -34,14 +35,14 @@ In order to use the new POM:
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>2.3</version> <!-- or later -->
<version>2.29</version> <!-- or whatever the newest version available is -->
<relativePath />
</parent>
```
* Override the needed properties, e.g.:
```xml
<properties>
<jenkins.version>1.609.1</jenkins.version>
<hpi-plugin.version>1.106</hpi-plugin.version>
</properties>
```

Expand All @@ -62,71 +63,55 @@ For example:
<id>jenkins-219</id>
<properties>
<jenkins.version>2.19.2</jenkins.version>
<hpi-plugin.version>1.120</hpi-plugin.version>
<stapler-plugin.version>1.17</stapler-plugin.version>
<java.level>7</java.level>
</properties>
</profile>
<profile>
<id>jenkins-27</id>
<properties>
<jenkins.version>2.7.3</jenkins.version>
<hpi-plugin.version>1.115</hpi-plugin.version>
<stapler-plugin.version>1.17</stapler-plugin.version>
<java.level>7</java.level>
</properties>
</profile>
<profile>
<id>jenkins-651</id>
<properties>
<jenkins.version>1.651.3</jenkins.version>
<hpi-plugin.version>1.115</hpi-plugin.version>
<stapler-plugin.version>1.17</stapler-plugin.version>
<java.level>7</java.level>
</properties>
</profile>
<profile>
<id>jenkins-642</id>
<properties>
<jenkins.version>1.642.4</jenkins.version>
<hpi-plugin.version>1.115</hpi-plugin.version>
<stapler-plugin.version>1.17</stapler-plugin.version>
<java.level>7</java.level>
</properties>
</profile>
<profile>
<id>jenkins-625</id>
<properties>
<jenkins.version>1.625.3</jenkins.version>
<hpi-plugin.version>1.106</hpi-plugin.version>
<stapler-plugin.version>1.17</stapler-plugin.version>
<java.level>7</java.level>
</properties>
</profile>
<profile>
<id>jenkins-609</id>
<properties>
<jenkins.version>1.609.3</jenkins.version>
<hpi-plugin.version>1.106</hpi-plugin.version>
<stapler-plugin.version>1.17</stapler-plugin.version>
<java.level>6</java.level>
</properties>
</profile>
<profile>
<id>jenkins-596</id>
<properties>
<jenkins.version>1.596.3</jenkins.version>
<hpi-plugin.version>1.106</hpi-plugin.version>
<stapler-plugin.version>1.17</stapler-plugin.version>
<java.level>6</java.level>
</properties>
</profile>
<profile>
<id>jenkins-580</id>
<properties>
<jenkins.version>1.580.3</jenkins.version>
<hpi-plugin.version>1.106</hpi-plugin.version>
<stapler-plugin.version>1.17</stapler-plugin.version>
<java.level>6</java.level>
</properties>
</profile>
Expand All @@ -135,8 +120,6 @@ For example:
<properties>
<jenkins.version>1.565.3</jenkins.version>
<jenkins-test-harness.version>1.565.3</jenkins-test-harness.version>
<hpi-plugin.version>1.106</hpi-plugin.version>
<stapler-plugin.version>1.17</stapler-plugin.version>
<java.level>6</java.level>
</properties>
</profile>
Expand Down
18 changes: 3 additions & 15 deletions pom.xml
Expand Up @@ -53,7 +53,7 @@
<jenkins-core.version>${jenkins.version}</jenkins-core.version>
<jenkins-war.version>${jenkins.version}</jenkins-war.version>
<jenkins-test-harness.version>2.22</jenkins-test-harness.version>
<hpi-plugin.version>1.122</hpi-plugin.version>
<hpi-plugin.version>2.0</hpi-plugin.version>
<stapler-plugin.version>1.17</stapler-plugin.version>
<java.level>7</java.level>
<!-- Change this property if you need your tests to be compiled with a different Java level than the plugin. -->
Expand Down Expand Up @@ -118,13 +118,7 @@
<groupId>org.jenkins-ci.main</groupId>
<artifactId>jenkins-war</artifactId>
<version>${jenkins-war.version}</version>
<classifier>war-for-test</classifier>
</dependency>
<dependency>
<groupId>org.jenkins-ci.main</groupId>
<artifactId>jenkins-war</artifactId>
<version>${jenkins-war.version}</version>
<type>war</type>
<type>executable-war</type>
<scope>test</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -237,13 +231,7 @@
<dependency>
<groupId>org.jenkins-ci.main</groupId>
<artifactId>jenkins-war</artifactId>
<classifier>war-for-test</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.main</groupId>
<artifactId>jenkins-war</artifactId>
<type>war</type>
<type>executable-war</type>
<scope>test</scope>
</dependency>
<dependency>
Expand Down

0 comments on commit 356fcf3

Please sign in to comment.