[FIXED JENKINS-25849] Do not log if parsing a blank string to int fails

jenkinsci · May 7, 2015 · e7bab51 · e7bab51
1 parent b2da484
commit e7bab51
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/main/java/hudson/plugins/plot/Plot.java b/src/main/java/hudson/plugins/plot/Plot.java
@@ -356,7 +356,7 @@ public String getNumBuilds() {
      */
     private void setRightBuildNum(StaplerRequest req) {
         String build = req.getParameter("rightbuildnum");
-        if (build == null) {
+        if (StringUtils.isBlank(build)) {
             rightBuildNum = Integer.MAX_VALUE;
         } else {
             try {
@@ -634,13 +634,20 @@ public String toString() {
                 url = record[4];
             dataset.setValue(value, url, series, xlabel);
         }
+
+        String urlNumBuilds = getURLNumBuilds();
         int numBuilds;
-        try {
-            numBuilds = Integer.parseInt(getURLNumBuilds());
-        } catch (NumberFormatException nfe) {
-            LOGGER.log(Level.SEVERE, "Exception converting to integer", nfe);
+        if (StringUtils.isBlank(urlNumBuilds)) {
             numBuilds = Integer.MAX_VALUE;
+        } else {
+            try {
+                numBuilds = Integer.parseInt(urlNumBuilds);
+            } catch (NumberFormatException nfe) {
+                LOGGER.log(Level.SEVERE, "Exception converting to integer", nfe);
+                numBuilds = Integer.MAX_VALUE;
+            }
         }
+
         dataset.clipDataset(numBuilds);
         plot = createChart(dataset);
         CategoryPlot categoryPlot = (CategoryPlot) plot.getPlot();