[JENKINS-26099] Permit StringCredentialsImpl.id and FileCredentialsIm…

…pl.id to be configured.
jenkinsci · Jan 14, 2015 · 0ba4a8a · 0ba4a8a
1 parent 846644a
commit 0ba4a8a
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 19 deletions.
diff --git a/pom.xml b/pom.xml
@@ -40,7 +40,7 @@
         <dependency>
             <groupId>org.jenkins-ci.plugins</groupId>
             <artifactId>credentials</artifactId>
-            <version>1.20</version>
+            <version>1.21-20150114.010642-1</version>
         </dependency>
     </dependencies>
     <build>

diff --git a/src/main/java/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl.java b/src/main/java/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl.java
@@ -24,7 +24,6 @@
 
 package org.jenkinsci.plugins.plaincredentials.impl;
 
-import com.cloudbees.plugins.credentials.CredentialsDescriptor;
 import com.cloudbees.plugins.credentials.CredentialsScope;
 import com.cloudbees.plugins.credentials.impl.BaseStandardCredentials;
 import hudson.Extension;
@@ -94,7 +93,7 @@ private byte[] unencrypted() throws IOException {
         return new ByteArrayInputStream(unencrypted());
     }
 
-    @Extension public static class DescriptorImpl extends CredentialsDescriptor {
+    @Extension public static class DescriptorImpl extends BaseStandardCredentialsDescriptor {
 
         @Override public String getDisplayName() {
             return Messages.FileCredentialsImpl_secret_file();

diff --git a/src/main/java/org/jenkinsci/plugins/plaincredentials/impl/StringCredentialsImpl.java b/src/main/java/org/jenkinsci/plugins/plaincredentials/impl/StringCredentialsImpl.java
@@ -24,7 +24,6 @@
 
 package org.jenkinsci.plugins.plaincredentials.impl;
 
-import com.cloudbees.plugins.credentials.CredentialsDescriptor;
 import com.cloudbees.plugins.credentials.CredentialsScope;
 import com.cloudbees.plugins.credentials.impl.BaseStandardCredentials;
 import hudson.Extension;
@@ -47,7 +46,7 @@ public final class StringCredentialsImpl extends BaseStandardCredentials impleme
         return secret;
     }
 
-    @Extension public static class DescriptorImpl extends CredentialsDescriptor {
+    @Extension public static class DescriptorImpl extends BaseStandardCredentialsDescriptor {
 
         @Override public String getDisplayName() {
             return Messages.StringCredentialsImpl_secret_text();

diff --git a/...sources/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl/credentials.jelly b/...sources/org/jenkinsci/plugins/plaincredentials/impl/FileCredentialsImpl/credentials.jelly
@@ -23,10 +23,7 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 -->
 <?jelly escape-by-default='true'?>
-<j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form">
-    <f:invisibleEntry>
-        <f:textbox field="id"/>
-    </f:invisibleEntry>
+<j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form" xmlns:st="jelly:stapler">
     <j:choose>
         <j:when test="${instance == null}">
             <f:entry title="${%File}" field="file">
@@ -47,7 +44,5 @@ THE SOFTWARE.
             </f:optionalBlock>
         </j:otherwise>
     </j:choose>
-    <f:entry title="${%Description}" field="description">
-        <f:textbox/>
-    </f:entry>
+    <st:include page="id-and-description" class="${descriptor.clazz}"/>
 </j:jelly>
diff --git a/...urces/org/jenkinsci/plugins/plaincredentials/impl/StringCredentialsImpl/credentials.jelly b/...urces/org/jenkinsci/plugins/plaincredentials/impl/StringCredentialsImpl/credentials.jelly
@@ -23,14 +23,9 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 -->
 <?jelly escape-by-default='true'?>
-<j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form">
-    <f:invisibleEntry>
-        <f:textbox field="id"/>
-    </f:invisibleEntry>
+<j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form" xmlns:st="jelly:stapler">
     <f:entry title="${%Secret}" field="secret">
         <f:password/>
     </f:entry>
-    <f:entry title="${%Description}" field="description">
-        <f:textbox/>
-    </f:entry>
+    <st:include page="id-and-description" class="${descriptor.clazz}"/>
 </j:jelly>