[JENKINS-43094] bug found by Findbugs!

jenkinsci · Jun 10, 2017 · 301bd81 · 301bd81
1 parent b3e48c2
commit 301bd81
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/...ava/org/jenkinsci/plugins/pipeline/maven/publishers/DependenciesFingerprintPublisher.java b/...ava/org/jenkinsci/plugins/pipeline/maven/publishers/DependenciesFingerprintPublisher.java
@@ -190,7 +190,7 @@ public List<MavenSpyLogProcessor.MavenDependency> listDependencies(Element maven
                 MavenSpyLogProcessor.MavenDependency dependencyArtifact = XmlUtils.newMavenDependency(dependencyElt);
 
                 Element fileElt = XmlUtils.getUniqueChildElementOrNull(dependencyElt, "file");
-                if (fileElt == null | fileElt.getTextContent() == null || fileElt.getTextContent().isEmpty()) {
+                if (fileElt == null || fileElt.getTextContent() == null || fileElt.getTextContent().isEmpty()) {
                     LOGGER.log(Level.WARNING, "listDependencies: no associated file found for " + dependencyArtifact + " in " + XmlUtils.toString(dependencyElt));
                 } else {
                     dependencyArtifact.file = StringUtils.trim(fileElt.getTextContent());