[JENKINS-40422] Use scanCredentials if available over checkoutCredent…

…ials When you use a separate set of credentials for checkout and scanning it makes sense to use the scan credentials to notify, for example it could be that checkout credentials are of type SSH whilst scan are of type username/ password, or even that due to GH API limits both of them may be adecuate but you want to use the scan ones
jenkinsci · Dec 18, 2016 · 77a59ad · 77a59ad
1 parent ecf5373
commit 77a59ad
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/...org/jenkinsci/plugins/pipeline/githubstatusnotification/GitHubStatusNotificationStep.java b/...org/jenkinsci/plugins/pipeline/githubstatusnotification/GitHubStatusNotificationStep.java
@@ -409,7 +409,10 @@ private String getSha1() {
         }
 
         private String tryToInferCredentialsId() {
-            String credentialsID = getSource().getCredentialsId();
+            // Try to use scan credentials if available, if not fall back to checkout credentials
+            String checkoutCredentials = getSource().getCredentialsId();
+            String scanCredentials = getSource().getScanCredentialsId();
+            String credentialsID = scanCredentials == null ? scanCredentials : checkoutCredentials;
             if (credentialsID != null) {
                 return credentialsID;
             } else {