[JENKINS-38887] Fix findbugs issues

jenkinsci · Mar 6, 2017 · 042679c · 042679c
1 parent f02e64e
commit 042679c
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/...in/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java b/...in/java/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStepExecution.java
@@ -124,13 +124,10 @@ protected Job asJob() {
             if (quietPeriod == null) {
                 quietPeriod = Jenkins.getActiveInstance().getQuietPeriod();
             }
-            ScheduleResult scheduleResult = Jenkins.getInstance().getQueue().schedule2(task, quietPeriod, actions);
-            if (scheduleResult.isRefused()) {
+            ScheduleResult scheduleResult = Jenkins.getActiveInstance().getQueue().schedule2(task, quietPeriod, actions);
+            if (scheduleResult.isRefused() || scheduleResult.getItem() == null) {
                 throw new AbortException("Failed to trigger build of " + item.getFullName());
             }
-            QueueTaskFuture<?> f =
-                    scheduleResult.getItem().getFuture();
-
         } else {
             throw new AbortException("The item named " + job + " is a "
                     + (item instanceof Describable