Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
JENKINS-49528 Peformance graphs for individual tests are not created …
…when a single test has failed
  • Loading branch information
eschava committed Feb 21, 2018
1 parent 0c10b5b commit f491327
Showing 1 changed file with 8 additions and 13 deletions.
21 changes: 8 additions & 13 deletions src/main/java/hudson/plugins/PerfPublisher/TestDetails.java
@@ -1,6 +1,5 @@
package hudson.plugins.PerfPublisher;

import hudson.model.Run;
import hudson.model.ModelObject;
import hudson.model.Result;
import hudson.model.Run;
Expand Down Expand Up @@ -123,13 +122,12 @@ public void doPerformanceGraph(StaplerRequest request,
}

private JFreeChart createPerformanceGraph() {
DataSetBuilder<String, NumberOnlyBuildLabel> builder = new DataSetBuilder<String, NumberOnlyBuildLabel>();
DataSetBuilder<String, NumberOnlyBuildLabel> builder = new DataSetBuilder<>();

for (Object build : _owner.getParent().getBuilds()) {
Run<?,?> abstractBuild = (Run<?,?>) build;
if (!abstractBuild.isBuilding()
&& abstractBuild.getResult().isBetterOrEqualTo(
Result.SUCCESS)) {
&& abstractBuild.getResult().isBetterOrEqualTo(Result.UNSTABLE)) {
PerfPublisherBuildAction action = abstractBuild
.getAction(PerfPublisherBuildAction.class);
if (action!=null && action.getReport() != null) {
Expand Down Expand Up @@ -182,13 +180,12 @@ public void doMetrics(StaplerRequest request,
}

private JFreeChart createMetricGraph(String metric) {
DataSetBuilder<String, NumberOnlyBuildLabel> builder = new DataSetBuilder<String, NumberOnlyBuildLabel>();
DataSetBuilder<String, NumberOnlyBuildLabel> builder = new DataSetBuilder<>();
String unit = null;
for (Object build : _owner.getParent().getBuilds()) {
Run<?,?> abstractBuild = (Run<?,?>) build;
if (!abstractBuild.isBuilding()
&& abstractBuild.getResult().isBetterOrEqualTo(
Result.UNSTABLE)) {
&& abstractBuild.getResult().isBetterOrEqualTo(Result.UNSTABLE)) {
PerfPublisherBuildAction action = abstractBuild
.getAction(PerfPublisherBuildAction.class);
if (action!=null && action.getReports() != null) {
Expand Down Expand Up @@ -246,13 +243,12 @@ public void doExecutionTimeGraph(StaplerRequest request,
}

private JFreeChart createExecutionTimeGraph() {
DataSetBuilder<String, NumberOnlyBuildLabel> builder = new DataSetBuilder<String, NumberOnlyBuildLabel>();
DataSetBuilder<String, NumberOnlyBuildLabel> builder = new DataSetBuilder<>();

for (Object build : _owner.getParent().getBuilds()) {
Run<?,?> abstractBuild = (Run<?,?>) build;
if (!abstractBuild.isBuilding()
&& abstractBuild.getResult().isBetterOrEqualTo(
Result.SUCCESS)) {
&& abstractBuild.getResult().isBetterOrEqualTo(Result.UNSTABLE)) {
PerfPublisherBuildAction action = abstractBuild
.getAction(PerfPublisherBuildAction.class);
if (action!=null && action.getReport() != null) {
Expand Down Expand Up @@ -307,13 +303,12 @@ public void doCompileTimeGraph(StaplerRequest request,
}

private JFreeChart createCompileTimeGraph() {
DataSetBuilder<String, NumberOnlyBuildLabel> builder = new DataSetBuilder<String, NumberOnlyBuildLabel>();
DataSetBuilder<String, NumberOnlyBuildLabel> builder = new DataSetBuilder<>();

for (Object build : _owner.getParent().getBuilds()) {
Run<?,?> abstractBuild = (Run<?,?>) build;
if (!abstractBuild.isBuilding()
&& abstractBuild.getResult().isBetterOrEqualTo(
Result.SUCCESS)) {
&& abstractBuild.getResult().isBetterOrEqualTo(Result.FAILURE)) {
PerfPublisherBuildAction action = abstractBuild
.getAction(PerfPublisherBuildAction.class);
if (action!=null && action.getReport() != null) {
Expand Down

0 comments on commit f491327

Please sign in to comment.