Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Merge pull request #49 from HexTank/master
Fix for JENKINS-11600, email-ext now queries getTimestamp and getCommite...
  • Loading branch information
rpetti committed Jul 17, 2014
2 parents 2da2bf9 + fda9b70 commit e49e9cb
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java
Expand Up @@ -65,9 +65,14 @@ public String getChangeNumber() {
}

//used for email-ext
@Deprecated
public String getRevision() {
return getChangeNumber();
}
//used for email-ext
public String getCommitId() {
return getChangeNumber();
}

@Exported
public String getChangeTime() {
Expand All @@ -76,9 +81,15 @@ public String getChangeTime() {
}

//used for email-ext
@Deprecated
public String getDate() {
return getChangeTime();
}
//used for email-ext
public long getTimestamp() {
return getChange().getDate().getTime();
}


/**
* {@inheritDoc}
Expand Down

5 comments on commit e49e9cb

@oleg-nenashev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpetti , are you going to release the plugin soon? The current SNAPSHOT version works well on our dev. servers

@rpetti
Copy link
Member Author

@rpetti rpetti commented on e49e9cb Oct 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to, but I can't build it and I don't have any time to set up a new development environment and track down all the deprecated dependencies it still needs.

@oleg-nenashev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind if I release it with 1.3.28 or 1.4.0 version?

@rpetti
Copy link
Member Author

@rpetti rpetti commented on e49e9cb Oct 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. If you think there have been enough enhancements and architectural changes to warrant a jump to 1.4.0, then go for it.

@oleg-nenashev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...the release failed due to the authorization issue during the upload to http://maven.jenkins-ci.org. Credentials/Maven settings seems to be OK. I'll check with @rtyler if everything is OK with the infrastructure

Please sign in to comment.