[FIXED JENKINS-13736] tagging now only requires the TAG permission

jenkinsci · May 10, 2012 · 2205924 · 2205924
1 parent d5ba5f9
commit 2205924
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/main/java/hudson/plugins/perforce/PerforceTagAction.java b/src/main/java/hudson/plugins/perforce/PerforceTagAction.java
@@ -8,6 +8,7 @@
 import hudson.model.Action;
 import hudson.model.Hudson;
 import hudson.scm.AbstractScmTagAction;
+import hudson.security.Permission;
 import hudson.util.FormValidation;
 import org.kohsuke.stapler.StaplerRequest;
 import org.kohsuke.stapler.StaplerResponse;
@@ -154,7 +155,7 @@ public synchronized FormValidation doCheckTag(@QueryParameter String value) {
      * Invoked to actually tag the workspace.
      */
     public synchronized void doSubmit(StaplerRequest req, StaplerResponse rsp) throws IOException, ServletException {
-        Hudson.getInstance().checkPermission(Hudson.ADMINISTER);
+        getACL().checkPermission(getPermission());
 
         String tag = req.getParameter("name");
         String desc = req.getParameter("desc");
@@ -233,5 +234,10 @@ public void setName(String name) {
         }
 
     }
+
+    @Override
+    protected Permission getPermission() {
+        return PerforceSCM.TAG;
+    }
 
 }