Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Enable Swarm builds on pipeline.
JENKINS-38233
- Loading branch information
Showing
2 changed files
with
34 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
src/main/java/org/jenkinsci/plugins/p4/review/ReviewActionFactory.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package org.jenkinsci.plugins.p4.review; | ||
|
||
import hudson.Extension; | ||
import hudson.model.Action; | ||
import hudson.model.Job; | ||
import jenkins.model.TransientActionFactory; | ||
|
||
import javax.annotation.Nonnull; | ||
import java.util.Collection; | ||
import java.util.Collections; | ||
|
||
@Extension | ||
public class ReviewActionFactory extends TransientActionFactory<Job> { | ||
|
||
@Override | ||
public Class<Job> type() { | ||
return Job.class; | ||
} | ||
|
||
@Nonnull | ||
@Override | ||
public Collection<? extends Action> createFor(@Nonnull Job target) { | ||
return Collections.singletonList(new ReviewAction(target)); | ||
} | ||
} |
73b4667
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this change is to blame but I'm observing a problem where builds are getting ignored while a swarm review queued item exists regardless of the different parameters.
73b4667
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I was wrong, it wasn't this change, it was 72cde84. I'll try to reach you directly in case you don't have visibility on these messages. In the meantime I locally rolled back where the safeparameter list was created to the old parameter list type and I'm no longer observing the issue with swarm review builds getting lost in the queue.
73b4667
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you raise a JIRA issue and assign it to me @p4paul - that way I hopefully won't forget to look into it.