Merge pull request #37 from i386/feature/JENKINS-41459

JENKINS-41459 fixes NPE when credential is null
jenkinsci · Feb 6, 2017 · 33d41b3 · 33d41b3
2 parents 6be7850 + f371bd2
commit 33d41b3
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java b/src/main/java/org/jenkinsci/plugins/p4/PerforceScm.java
@@ -215,8 +215,12 @@ public String getKey() {
 
 	@Override
 	public RepositoryBrowser<?> guessBrowser() {
+		String scmCredential = getCredential();
+		if (scmCredential == null) {
+			logger.fine("No credential for perforce");
+			return null;
+		}
 		try {
-			String scmCredential = getCredential();
 			ConnectionHelper connection = new ConnectionHelper(scmCredential, null);
 			String swarm = connection.getSwarm();
 			URL url = new URL(swarm);