[JENKINS-40624] Fix test case, miss to remove assert on environment

jenkinsci · Feb 7, 2017 · 15db7f5 · 15db7f5
1 parent 7747247
commit 15db7f5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstallation.java b/src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstallation.java
@@ -11,6 +11,7 @@
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.StaplerRequest;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.EnvVars;
 import hudson.Extension;
 import hudson.Util;
@@ -33,8 +34,10 @@
  * @author Nikolas Falco
  */
 @SuppressWarnings("serial")
+@SuppressFBWarnings(value = "SE_NO_SERIALVERSIONID")
 public class NodeJSInstallation extends ToolInstallation implements EnvironmentSpecific<NodeJSInstallation>, NodeSpecific<NodeJSInstallation> {
 
+    @SuppressFBWarnings(value = "SE_TRANSIENT_FIELD_NOT_RESTORED", justification = "calculate at runtime, its value depends on the OS where it run")
     private final transient Platform platform;
 
     @DataBoundConstructor

diff --git a/src/test/java/jenkins/plugins/nodejs/NpmrcFileSupplyTest.java b/src/test/java/jenkins/plugins/nodejs/NpmrcFileSupplyTest.java
@@ -58,8 +58,6 @@ public void test_supply_npmrc_with_registry() throws Exception {
         Npmrc npmrc = Npmrc.load(new File(npmrcFile.getRemote()));
         assertTrue("Missing setting email", npmrc.contains("email"));
         assertEquals("Unexpected value from settings email", "guest@example.com", npmrc.get("email"));
-
-        assertFalse("No environment found", enviroments.isEmpty());
     }
 
     private StandardUsernameCredentials createUser(String id, String username, String password) {