[JENKINS-11877] Don't attempt changelog calculation if clone/update f…

…ailed
jenkinsci · Dec 4, 2011 · f06a86a · kutzi · Dec 4, 2011 · f06a86a
1 parent a3735a5
commit f06a86a
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/src/main/java/hudson/plugins/mercurial/MercurialSCM.java b/src/main/java/hudson/plugins/mercurial/MercurialSCM.java
@@ -385,14 +385,16 @@ public boolean checkout(AbstractBuild<?,?> build, Launcher launcher, FilePath wo
             success = clone(build, launcher, repository, listener);
         }
 
-        try {
-            determineChanges(build, launcher, listener, changelogFile, repository);
-            return success;
-        } catch (IOException e) {
-            listener.error("Failed to capture change log");
-            e.printStackTrace(listener.getLogger());
-            return false;
-        } 
+        if (success) {
+            try {
+                determineChanges(build, launcher, listener, changelogFile, repository);
+            } catch (IOException e) {
+                listener.error("Failed to capture change log");
+                e.printStackTrace(listener.getLogger());
+                success = false;
+            }
+        }
+        return success;
     }
 
     private boolean canReuseWorkspace(FilePath repo,