Skip to content

Commit

Permalink
[FIXED JENKINS-18589]
Browse files Browse the repository at this point in the history
Use DescribableList to handle the copy-on-write semantics correctly. The vector class just doesn't cut it, and we've been setting a new value to this field, which will violates all sorts of the concurrent programming practice.

This change has the nice side effect of removing {{class="vector"}} from the persisted XML. A test is added to make sure we can still read back such an XML.

Originally-Committed-As: 7facc7733c7040536d4074a2c5805b75ee1d8f35
  • Loading branch information
kohsuke committed Jul 2, 2013
1 parent 4f70763 commit a779e67
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/java/hudson/maven/AbstractMavenProject.java
Expand Up @@ -184,7 +184,7 @@ protected List<Action> createTransientActions() {
addTransientActionsFromBuild(getLastBuild(),r,added);
addTransientActionsFromBuild(getLastSuccessfulBuild(),r,added);

for (Trigger<?> trigger : triggers)
for (Trigger<?> trigger : triggers())
r.addAll(trigger.getProjectActions());

return r;
Expand Down

0 comments on commit a779e67

Please sign in to comment.