Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[FIXED JENKINS-20221] wrong data binding failed job saving
  • Loading branch information
Stefan Brausch committed Oct 26, 2013
1 parent 912fefe commit aa4593d
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 28 deletions.
4 changes: 4 additions & 0 deletions .gitignore
@@ -0,0 +1,4 @@
.classpath
.project
.settings/
target/
Expand Up @@ -198,22 +198,6 @@ public boolean configure(StaplerRequest req, JSONObject formData) throws FormExc
return super.configure(req, formData);
}

@Override
public BuildWrapper newInstance(StaplerRequest req, JSONObject formData)
throws FormException {

final JSONObject newData = new JSONObject();
newData.put("failBuild", formData.getString("failBuild"));

final JSONObject sizeObject = formData.getJSONObject("logfilesizechecker");
if ("setOwn".equals(sizeObject.getString("value"))) {
newData.put("setOwn", true);
newData.put("maxLogSize", sizeObject.getString("maxLogSize"));
} else {
newData.put("setOwn", false);
}

return super.newInstance(req, newData);
}

}
}
@@ -1,13 +1,13 @@
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">

<f:radioBlock name="logfilesizechecker" value="useDefault" title="${%Use default maximum log size} (${descriptor.getDefaultLogSize()} MB)" checked="${!instance.setOwn}"/>

<f:radioBlock name="logfilesizechecker" value="setOwn" title="${%Set job specific maximum log size}" checked="${instance.setOwn}">
<f:entry title="${%Max Log Size in MB}" field="maxLogSize">
<f:textbox/>
</f:entry>
</f:radioBlock>

<f:entry title="${%Use job specific maximum log size instead global value} (${descriptor.getDefaultLogSize()} MB)" field="setOwn">
<f:checkbox/>
</f:entry>
<f:entry title="${%Job specific max log size in MB}" field="maxLogSize">
<f:textbox/>
</f:entry>
<f:entry title="${%Fail the build}" field="failBuild">
<f:checkbox/>
</f:entry>
Expand Down
@@ -1,4 +1,4 @@
Fail\ the\ build=Build\ als\ fehlgeschlagen\ markieren
Max\ Log\ Size\ in\ MB=Maximale\ Größe\ der\ Logdatei\ in\ MB
Set\ job\ specific\ maximum\ log\ size=Maximale\ Logdateigröße\ für\ diesen\ Job\ festlegen
Use\ default\ maximum\ log\ size=Maximale\ Logdateigröße\ aus\ Jenkinskonfiguration\ übernehmen
Job\ specific\ max\ log\ size\ in\ MB=Job\ spezifische\ Maximale\ Größe\ der\ Logdatei\ in\ MB
Use\ job\ specific\ maximum\ log\ size\ instead\ global\ value=Job\ spezifische\ Logdateigröße\ für\ diesen\ Job\ anstelle\ des\ globalen\ Wertes\ verwenden

0 comments on commit aa4593d

Please sign in to comment.