[JENKINS-50204] Ensure user has permission to view credentials.

jenkinsci · Apr 13, 2018 · 7dad737 · 7dad737
1 parent 6a1ad95
commit 7dad737
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...cloudbees/jenkins/plugins/kubernetes_credentials_provider/KubernetesCredentialsStore.java b/...cloudbees/jenkins/plugins/kubernetes_credentials_provider/KubernetesCredentialsStore.java
@@ -45,9 +45,9 @@ public boolean hasPermission(@NonNull Authentication authentication, @NonNull Pe
     @Override
     public List<Credentials> getCredentials(@NonNull Domain domain) {
         // Only the global domain is supported
-        return Domain.global().equals(domain)
-               ? provider.getCredentials(Credentials.class, Jenkins.getInstance(), ACL.SYSTEM)
-               : Collections.emptyList();
+        if (Domain.global().equals(domain) && Jenkins.getInstance().hasPermission(CredentialsProvider.VIEW))
+            return provider.getCredentials(Credentials.class, Jenkins.getInstance(), ACL.SYSTEM);
+        return Collections.emptyList();
     }
 
     @Override