Merge pull request #16 from miyajan/JENKINS-37026

[JENKINS-37026] Fix to encode URL to attachments
jenkinsci · Feb 22, 2018 · 579bba5 · 579bba5
2 parents 5914e4a + a6341ac
commit 579bba5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/main/java/hudson/plugins/junitattachments/AttachmentTestAction.java b/src/main/java/hudson/plugins/junitattachments/AttachmentTestAction.java
@@ -6,6 +6,8 @@
 import hudson.tasks.test.TestObject;
 import jenkins.model.Jenkins;
 
+import java.io.UnsupportedEncodingException;
+import java.net.URLEncoder;
 import java.util.List;
 
 public class AttachmentTestAction extends TestAction {
@@ -60,4 +62,8 @@ public static boolean isImageFile(String filename) {
 		return filename.matches("(?i).+\\.(gif|jpe?g|png)$");
 	}
 
+	public static String getUrl(String filename) throws UnsupportedEncodingException {
+		return "attachments/" + URLEncoder.encode(filename, "UTF-8");
+	}
+
 }
diff --git a/src/main/resources/hudson/plugins/junitattachments/AttachmentTestAction/summary.jelly b/src/main/resources/hudson/plugins/junitattachments/AttachmentTestAction/summary.jelly
@@ -13,7 +13,7 @@
 					<td class="pane">
 						<a class="${it.isImageFile(attachment) ? 'gallery' : ''}"
 						   title="${attachment}"
-						   href="attachments/${attachment}">${attachment}</a>
+						   href="${it.getUrl(attachment)}">${attachment}</a>
 					</td>
 				</tr>
 			</j:forEach>