avoid NPE in readFileFromWorkspace

[FIXES JENKINS-43537]
jenkinsci · Apr 12, 2017 · c543398 · c543398
1 parent b5146c8
commit c543398
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/docs/Home.md b/docs/Home.md
@@ -29,6 +29,8 @@ Browse the Jenkins issue tracker to see any [open issues](https://issues.jenkins
 
 ## Release Notes
 * 1.61 (unreleased)
+  * Fixed a problem with `readFileFromWorkspace`
+    ([JENKINS-43537](https://issues.jenkins-ci.org/browse/JENKINS-43537))
 * 1.60 (April 10 2017)
   * Enabled script approval with the
     [Script Security Plugin](https://wiki.jenkins-ci.org/display/JENKINS/Script+Security+Plugin), see

diff --git a/job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobManagement.java b/job-dsl-plugin/src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobManagement.java
@@ -263,14 +263,18 @@ public void queueJob(String path) throws NameNotProvidedException {
 
     @Override
     public InputStream streamFileInWorkspace(String relLocation) throws IOException, InterruptedException {
-        project.checkPermission(Item.WORKSPACE);
+        if (project != null) {
+            project.checkPermission(Item.WORKSPACE);
+        }
         FilePath filePath = locateValidFileInWorkspace(workspace, relLocation);
         return filePath.read();
     }
 
     @Override
     public String readFileInWorkspace(String relLocation) throws IOException, InterruptedException {
-        project.checkPermission(Item.WORKSPACE);
+        if (project != null) {
+            project.checkPermission(Item.WORKSPACE);
+        }
         FilePath filePath = locateValidFileInWorkspace(workspace, relLocation);
         return filePath.readToString();
     }