[FIXED JENKINS-13998] Fix NPE when Jenkins user does not have access …

…to perform any workflow actions.
jenkinsci · Jun 1, 2012 · 05a4e5c · 05a4e5c
1 parent e2f6768
commit 05a4e5c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/src/main/java/hudson/plugins/jira/JiraSession.java b/src/main/java/hudson/plugins/jira/JiraSession.java
@@ -290,10 +290,12 @@ public String progressWorkflowAction(String issueKey, String workflowActionName,
     public String getActionIdForIssue(String issueKey, String workflowAction) throws RemoteException {
         RemoteNamedObject[] actions = service.getAvailableActions(token, issueKey);
 
-        for (RemoteNamedObject action : actions) {
-            if (action.getName().equalsIgnoreCase(workflowAction)) {
-                return action.getId();
-            }
+        if (actions != null) {
+	        for (RemoteNamedObject action : actions) {
+	            if (workflowAction.equalsIgnoreCase(action.getName())) {
+	                return action.getId();
+	            }
+	        }
         }
 
         return null;

diff --git a/src/main/resources/hudson/plugins/jira/JiraIssueUpdateBuilder/help-workflowActionName.html b/src/main/resources/hudson/plugins/jira/JiraIssueUpdateBuilder/help-workflowActionName.html
@@ -2,4 +2,6 @@
   The workflow action to be performed on the selected JIRA issues.
   <p />
   Be mindful of the issues being selected by the JQL query, because not all actions are valid for all issue statuses.
+  <p />
+  <b>NOTE:</b> the Jenkins user must have access to perform the workflow step, as if the user were logged in and viewing the issue in a web browser. 
 </div>
diff --git a/src/main/resources/hudson/plugins/jira/Messages.properties b/src/main/resources/hudson/plugins/jira/Messages.properties
@@ -16,5 +16,5 @@ JiraIssueUpdateBuilder.NoJqlSearch=Please set the JQL used to select the issues
 JiraIssueUpdateBuilder.NoWorkflowAction=A workflow action is required.
 JiraIssueUpdateBuilder.UpdatingWithAction=[JIRA] Updating issues using workflow action {0}.
 JiraIssueUpdateBuilder.Failed=[JIRA] An error occurred while progressing issues:
-JiraIssueUpdateBuilder.UnknownWorkflowAction=[JIRA] Unable to update issue {0}: invalid workflow action "{1}".
+JiraIssueUpdateBuilder.UnknownWorkflowAction=[JIRA] Unable to update issue {0}: invalid workflow action "{1}". Perhaps the Jenkins user does not have permission to perform the action on the JIRA issue?
 JiraIssueUpdateBuilder.SomeIssuesFailed=[JIRA] At least one issue failed to update.  See log above for more details.