JENKINS-27183 Avoid deadlock when using build-monitor-plugin

jenkinsci · Mar 9, 2015 · fb5540e · fb5540e
1 parent e9bf4b7
commit fb5540e
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/core/src/main/java/hudson/model/AbstractItem.java b/core/src/main/java/hudson/model/AbstractItem.java
@@ -216,6 +216,8 @@ protected void doSetName(String name) {
     protected void renameTo(final String newName) throws IOException {
         // always synchronize from bigger objects first
         final ItemGroup parent = getParent();
+        String oldName = this.name;
+        String oldFullName = getFullName();
         synchronized (parent) {
             synchronized (this) {
                 // sanity check
@@ -248,9 +250,6 @@ public Void call() throws IOException {
                     }
                 });
 
-
-                String oldName = this.name;
-                String oldFullName = getFullName();
                 File oldRoot = this.getRootDir();
 
                 doSetName(newName);
@@ -324,10 +323,9 @@ public Void call() throws IOException {
                 } catch (AbstractMethodError _) {
                     // ignore
                 }
-
-                ItemListener.fireLocationChange(this, oldFullName);
             }
         }
+        ItemListener.fireLocationChange(this, oldFullName);
     }