[JENKINS-5577] A better way to implement this is to extend from

StringParameterDefinition and reuse most of its views.
jenkinsci · Jun 15, 2011 · f766f2a · f766f2a
1 parent d0d5ea3
commit f766f2a
Show file tree

Hide file tree

Showing 10 changed files with 3 additions and 266 deletions.
diff --git a/core/src/main/java/hudson/model/TextParameterDefinition.java b/core/src/main/java/hudson/model/TextParameterDefinition.java
@@ -29,44 +29,12 @@
 import org.kohsuke.stapler.StaplerRequest;
 
 /**
- * Parameter whose value is a string value.
+ * {@link StringParameterDefinition} that uses textarea, instead of text box.
  */
-public class TextParameterDefinition extends SimpleParameterDefinition {
-
-    private String defaultValue;
-
+public class TextParameterDefinition extends StringParameterDefinition {
     @DataBoundConstructor
     public TextParameterDefinition(String name, String defaultValue, String description) {
-        super(name, description);
-        this.defaultValue = defaultValue;
-    }
-
-    public TextParameterDefinition(String name, String defaultValue) {
-        this(name, defaultValue, null);
-    }
-
-    @Override
-    public ParameterDefinition copyWithDefaultValue(ParameterValue defaultValue) {
-        if (defaultValue instanceof StringParameterValue) {
-            StringParameterValue value = (StringParameterValue) defaultValue;
-            return new TextParameterDefinition(getName(), value.value, getDescription());
-        } else {
-            return this;
-        }
-    }
-
-    public String getDefaultValue() {
-        return defaultValue;
-    }
-
-    public void setDefaultValue(String defaultValue) {
-        this.defaultValue = defaultValue;
-    }
-
-    @Override
-    public StringParameterValue getDefaultParameterValue() {
-        StringParameterValue v = new StringParameterValue(getName(), defaultValue, getDescription());
-        return v;
+        super(name, defaultValue, description);
     }
 
     @Extension
@@ -75,21 +43,5 @@ public static class DescriptorImpl extends ParameterDescriptor {
         public String getDisplayName() {
             return Messages.TextParameterDefinition_DisplayName();
         }
-
-        @Override
-        public String getHelpFile() {
-            return "/help/parameter/string.html";
-        }
-    }
-
-    @Override
-    public ParameterValue createValue(StaplerRequest req, JSONObject jo) {
-        StringParameterValue value = req.bindJSON(StringParameterValue.class, jo);
-        value.setDescription(getDescription());
-        return value;
-    }
-
-    public ParameterValue createValue(String value) {
-        return new StringParameterValue(getName(), value, getDescription());
     }
 }
diff --git a/core/src/main/resources/hudson/model/TextParameterDefinition/config.jelly b/core/src/main/resources/hudson/model/TextParameterDefinition/config.jelly
diff --git a/core/src/main/resources/hudson/model/TextParameterDefinition/config_da.properties b/core/src/main/resources/hudson/model/TextParameterDefinition/config_da.properties
diff --git a/core/src/main/resources/hudson/model/TextParameterDefinition/config_de.properties b/core/src/main/resources/hudson/model/TextParameterDefinition/config_de.properties
diff --git a/core/src/main/resources/hudson/model/TextParameterDefinition/config_es.properties b/core/src/main/resources/hudson/model/TextParameterDefinition/config_es.properties
diff --git a/core/src/main/resources/hudson/model/TextParameterDefinition/config_fr.properties b/core/src/main/resources/hudson/model/TextParameterDefinition/config_fr.properties
diff --git a/core/src/main/resources/hudson/model/TextParameterDefinition/config_ja.properties b/core/src/main/resources/hudson/model/TextParameterDefinition/config_ja.properties
diff --git a/core/src/main/resources/hudson/model/TextParameterDefinition/config_pt_BR.properties b/core/src/main/resources/hudson/model/TextParameterDefinition/config_pt_BR.properties
diff --git a/core/src/main/resources/hudson/model/TextParameterDefinition/config_ru.properties b/core/src/main/resources/hudson/model/TextParameterDefinition/config_ru.properties
diff --git a/core/src/main/resources/hudson/model/TextParameterDefinition/config_zh_TW.properties b/core/src/main/resources/hudson/model/TextParameterDefinition/config_zh_TW.properties