Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FIXED JENKINS-33780] Introduce NodeListener
- Loading branch information
1 parent
7a899d4
commit f21fe54
Showing
4 changed files
with
150 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
/* | ||
* The MIT License | ||
* | ||
* Copyright (c) Red Hat, Inc. | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in | ||
* all copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
* THE SOFTWARE. | ||
*/ | ||
package jenkins.model; | ||
|
||
import hudson.ExtensionList; | ||
import hudson.ExtensionPoint; | ||
import hudson.model.Node; | ||
|
||
import javax.annotation.Nonnull; | ||
import java.util.List; | ||
|
||
/** | ||
* Listen to {@link Node} CRUD operations. | ||
* | ||
* @author ogondza. | ||
* @since TODO | ||
*/ | ||
public abstract class NodeListener implements ExtensionPoint { | ||
|
||
protected void onCreated(@Nonnull Node node) {} | ||
|
||
protected void onUpdated(@Nonnull Node oldOne, @Nonnull Node newOne) {} | ||
|
||
protected void onDeleted(@Nonnull Node node) {} | ||
|
||
public static void fireOnCreated(@Nonnull Node node) { | ||
for (NodeListener nl: all()) { | ||
nl.onCreated(node); | ||
} | ||
} | ||
|
||
public static void fireOnUpdated(@Nonnull Node oldOne, @Nonnull Node newOne) { | ||
for (NodeListener nl: all()) { | ||
nl.onUpdated(oldOne, newOne); | ||
} | ||
} | ||
|
||
public static void fireOnDeleted(@Nonnull Node node) { | ||
for (NodeListener nl: all()) { | ||
nl.onDeleted(node); | ||
} | ||
} | ||
|
||
public static @Nonnull List<NodeListener> all() { | ||
return ExtensionList.lookup(NodeListener.class); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
package jenkins.model; | ||
|
||
import hudson.ExtensionList; | ||
import hudson.cli.CLICommand; | ||
import hudson.cli.CLICommandInvoker; | ||
import hudson.cli.CreateNodeCommand; | ||
import hudson.cli.DeleteNodeCommand; | ||
import hudson.cli.GetNodeCommand; | ||
import hudson.cli.UpdateNodeCommand; | ||
import hudson.model.Node; | ||
import hudson.slaves.DumbSlave; | ||
import org.apache.tools.ant.filters.StringInputStream; | ||
import org.junit.Before; | ||
import org.junit.Rule; | ||
import org.junit.Test; | ||
import org.jvnet.hudson.test.JenkinsRule; | ||
|
||
import static org.mockito.Mockito.*; | ||
|
||
public class NodeListenerTest { | ||
|
||
@Rule public JenkinsRule j = new JenkinsRule(); | ||
|
||
private NodeListener mock; | ||
|
||
@Before | ||
public void setUp() { | ||
mock = mock(NodeListener.class); | ||
ExtensionList.lookup(NodeListener.class).add(mock); | ||
} | ||
|
||
@Test | ||
public void crud() throws Exception { | ||
DumbSlave slave = j.createSlave(); | ||
String xml = cli(new GetNodeCommand()).invokeWithArgs(slave.getNodeName()).stdout(); | ||
cli(new UpdateNodeCommand()).withStdin(new StringInputStream(xml)).invokeWithArgs(slave.getNodeName()); | ||
cli(new DeleteNodeCommand()).invokeWithArgs(slave.getNodeName()); | ||
|
||
cli(new CreateNodeCommand()).withStdin(new StringInputStream(xml)).invokeWithArgs("replica"); | ||
j.jenkins.getComputer("replica").doDoDelete(); | ||
|
||
verify(mock, times(2)).onCreated(any(Node.class)); | ||
verify(mock, times(1)).onUpdated(any(Node.class), any(Node.class)); | ||
verify(mock, times(2)).onDeleted(any(Node.class)); | ||
verifyNoMoreInteractions(mock); | ||
} | ||
|
||
private CLICommandInvoker cli(CLICommand cmd) { | ||
return new CLICommandInvoker(j, cmd); | ||
} | ||
} |